Handle invalid UTF-8 in source code #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
commented
Aug 5, 2024
| × decoding error | ||
| ╭──── | ||
| 1 │ malformed h�XYZ | ||
| · ┬ |
There was a problem hiding this comment.
This is correctly pointing at the X, although it is hard to tell from the Github preview.
|
what's the deal with clippy. sigh. |
|
awesome thanks. You can rebase now. |
Fixed the 1.70 build as well. Should be good to go. |
zkat
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if invalid UTF-8 is passed to the source code, then the
Reportwill panic when rendered. This PR changes it to properly decode UTF-8 and handle the invalid data in the usual way (i.e. they will be replaced with �).This can require an extra allocation when rendering
Report, but only for invalid UTF-8, and only for the "context" area, which is usually small (several lines).This is simply a one-line change, but there are tests to double-check the behaviour of offsets into invalid source. I added some tests for labels into "good" Unicode source and also into "bad" Unicode source. Both seem to behave as expected.