Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve NFC reading UX on android #130 #168

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Conversation

BernalHQ
Copy link
Contributor

@BernalHQ BernalHQ commented Aug 7, 2024

**What kind of change does this PR introduce?
This PR improve NFC UX on android

What is the current behavior?

Do not show to the user a animation about the passport scan process #130

What is the new behavior?
Show a message animation with the phases of the passport scan process to by more interactive to the user

@remicolin remicolin changed the base branch from main to dev August 7, 2024 09:47
@remicolin
Copy link
Collaborator

i switched base from main to dev branch.
there is conflicts in two files that seems easy to fix.
i you have hard time into merging code grant me the right access to your repo.

@BernalHQ
Copy link
Contributor Author

BernalHQ commented Aug 7, 2024

@remicolin, I gave you access to the repository, could you help me with merge please?

@remicolin remicolin merged commit 383be7d into zk-passport:dev Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants