Review ZValidation code: Remove some non-necessary allocations
#1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
reviewed
Aug 12, 2024
| @@ -75,8 +75,8 @@ sealed trait ZValidation[+W, +E, +A] { self => | |||
| */ | |||
| final def flatMap[W1 >: W, E1 >: E, B](f: A => ZValidation[W1, E1, B]): ZValidation[W1, E1, B] = | |||
| self match { | |||
| case Failure(w, e) => Failure(w, e) | |||
| case Success(w, a) => | |||
| case failure @ Failure(_, _) => failure | |||
There was a problem hiding this comment.
From a performance perspective, I think this is probably better as it avoids extracting the case class params:
case failure: Failure[E1, B] => failureDepending on the scalac flags this might raise a warning (I think if the unchecked flag is used) , in which case you can do this:
case failure: Failure[E1 @unchecked, B @unchecked] => failure
// Or alias the annotation to reduce boilerplate:
import scala.{ unchecked => uc }
|
@kyri-petrou Thanks for your review. I updated the PR |
kyri-petrou
approved these changes
Aug 13, 2024
|
Thanks @kyri-petrou @sideeffffect 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.