-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql): Support custom equality function for cache comparison #1431
feat(graphql): Support custom equality function for cache comparison #1431
Conversation
LGTM, I am wondering if you can work around about the test failure?
It is just a |
Got it! Removed the unused important. I also cleaned it up a little
Would you like me to document the new constructor argument? Or leave it as it is now with the global being documented? |
@vincenzopalazzo is this something we can get in so I don't have to use a forked version? :) |
Ops I missed this for some reason, we can remove the merge commits @kvenn ? Maybe just rebasing on main? Thanks |
sorry for bumping this again @kvenn. Would be nice to do the above to get it in or if you are swamped I could make a PR |
b402de8
to
b1c4bf8
Compare
I rebased and squashed all my commits together. Please let me know if there's anything else I can do! We've been using this fork for the past 2 months and it's been blazing fast! Also, if you'd like to keep the git history clean, squash merging these types of feature branches seems like a good alternative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks!
It need to be rebased on main and then we are good to go
- The current equality check has received some dissatisfaction due to performance (and is a source of jank/missed frames in my application) - This is an unopinionated way to allow those consumers to provide their own equality function with better performance via optimizedDeepEquals
b1c4bf8
to
a6909d4
Compare
Done! Thanks for the reviews :) |
Summary
Details
const DeepCollectionEquality().equals
optimizedDeepEquals
)