feat(graphql_common): add common package that contains utils functions #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
added
the
dart client
vincenzopalazzo
force-pushed
the
macros/tracing
branch
from
2aa26a0
to
16e8ca4
Compare
|
I think this is ready to get merged, but maybe after the official 5.1.2 release and we get it inside the 5.2.0-beta.1 What do you think? @budde377 |
|
The CI failure is unrelated we should publish our first common version but let do the more important stuff before |
Signed-off-by: Vincenzo Palazzo <[email protected]>
… lib Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/tracing
branch
from
00dfdb4
to
3a41156
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/tracing
branch
from
3a41156
to
bc7bdc3
Compare
|
@budde377 this should be ready to be merged, and later I need to document it, but for now it is just a internal package so imho it is ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a big lack in the library, we can not trace in case of a fancy problem, with this PR I'm proposing to put a generic interface + a Logger trace inside a separate package, and use it inside the client.
This will help us to safely make refactoring and trace the example that I proposed in other open PRs today!