Skip to content

Commit

Permalink
upgrade node.js version to 22 for the docker image (#666)
Browse files Browse the repository at this point in the history
* upgrade node.js version to 22 for the docker image

Signed-off-by: ryjiang <[email protected]>

* update ci node version

Signed-off-by: ryjiang <[email protected]>

---------

Signed-off-by: ryjiang <[email protected]>
  • Loading branch information
shanghaikid authored Oct 18, 2024
1 parent 3530fab commit e2e4baa
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22

# - name: Run server tests
# run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/electron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22

- name: Build client
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# => Building container
FROM --platform=$TARGETPLATFORM node:18-slim as builder
FROM --platform=$TARGETPLATFORM node:22-slim as builder
WORKDIR /app
COPY . .

Expand All @@ -19,7 +19,7 @@ ENV PORT 80
RUN yarn build

# => Copy to Final container
FROM --platform=$TARGETPLATFORM node:18-slim
FROM --platform=$TARGETPLATFORM node:22-slim
WORKDIR /app
COPY --from=builder /app/server/dist /app/dist
COPY --from=builder /app/client/build /app/build
Expand Down

0 comments on commit e2e4baa

Please sign in to comment.