Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Royal Gardineer Irrigation Valve. #3505

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

mrrstux
Copy link

@mrrstux mrrstux commented Nov 10, 2024

Proposed change

Quirk for supporting Royal Gardineer valve.
Similar to this device.

Additional information

Exposes:

  • open/close command
  • battery remaining percentage
  • water consumption
  • timer time left
  • timer state
  • last open duration
  • weather delay

Valve works on a timer only, with a default timer of 10 minutes. Before opening the valve, it is recommended to set the irrigation desired time in the "Timer time left" field.

Checklist

  • [ x] The changes are tested and work correctly
  • [ x] pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (728ee42) to head (2454a60).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3505      +/-   ##
==========================================
+ Coverage   89.44%   89.45%   +0.01%     
==========================================
  Files         311      311              
  Lines       10033    10043      +10     
==========================================
+ Hits         8974     8984      +10     
  Misses       1059     1059              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant