-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HZC D688-ZG dimmer switch quirk #3362
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3362 +/- ##
==========================================
+ Coverage 88.49% 88.50% +0.01%
==========================================
Files 305 306 +1
Lines 9621 9633 +12
==========================================
+ Hits 8514 8526 +12
Misses 1107 1107 ☔ View full report in Codecov by Sentry. |
Still verifying functionality |
I have these switches with two different firmwares where firmware 0x00000001 behaves OK even without the quirk, the ones with 0x00000002 will turn on and off repeatedly and throw error messages without the quirk. With quirk both versions operate fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@TheJulianJES could you also add the similar dimmer from EcoDim to this quirk? See #2865 for the info. Note that it is a two gang dimmer though. This I think would fix that longstanding issue also! :) |
Inspired by zigpy#3362
Proposed change
Add quirk for HZC Dimmer-Switch-ZB3.0 Rotary Dimmer. Shout out to @EmberLightVFX for making the quirk.
Additional information
Fixes #2987
Checklist
pre-commit
checks pass / the code has been formatted using Black