Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HZC D688-ZG dimmer switch quirk #3362

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

jagheterfredrik
Copy link
Contributor

@jagheterfredrik jagheterfredrik commented Sep 14, 2024

Proposed change

Add quirk for HZC Dimmer-Switch-ZB3.0 Rotary Dimmer. Shout out to @EmberLightVFX for making the quirk.

Additional information

Fixes #2987

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (acecf70) to head (d2814a6).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3362      +/-   ##
==========================================
+ Coverage   88.49%   88.50%   +0.01%     
==========================================
  Files         305      306       +1     
  Lines        9621     9633      +12     
==========================================
+ Hits         8514     8526      +12     
  Misses       1107     1107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jagheterfredrik jagheterfredrik marked this pull request as draft September 14, 2024 18:32
@jagheterfredrik
Copy link
Contributor Author

Still verifying functionality

@jagheterfredrik
Copy link
Contributor Author

jagheterfredrik commented Sep 14, 2024

I have these switches with two different firmwares where firmware 0x00000001 behaves OK even without the quirk, the ones with 0x00000002 will turn on and off repeatedly and throw error messages without the quirk. With quirk both versions operate fine.

@jagheterfredrik jagheterfredrik marked this pull request as ready for review September 14, 2024 18:42
@TheJulianJES TheJulianJES changed the title add HZC D688-ZG quirk Add HZC D688-ZG dimmer switch quirk Sep 16, 2024
@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Sep 16, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 8145087 into zigpy:dev Sep 24, 2024
7 checks passed
@mano3m
Copy link

mano3m commented Oct 12, 2024

@TheJulianJES could you also add the similar dimmer from EcoDim to this quirk? See #2865 for the info. Note that it is a two gang dimmer though. This I think would fix that longstanding issue also! :)

https://www.hzc-electric.com/pro_view-88.html

mano3m added a commit to mano3m/zha-device-handlers that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] HZC Electronics D688-ZG
3 participants