Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quirk for Sonoff TRVZB #3358

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add quirk for Sonoff TRVZB #3358

wants to merge 1 commit into from

Conversation

fgsch
Copy link

@fgsch fgsch commented Sep 11, 2024

Proposed change

Add a quirk for Sonoff TRVZB. This is an alternative PR to #2831 using the quirks builder.

Additional information

String translations will need to be added iff / when this is merged:


translation key string
frost_protection_temperature Frost protection temperature
open_window Open window

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.50%. Comparing base (acecf70) to head (c21ca2a).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/sonoff/trvzb.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3358      +/-   ##
==========================================
+ Coverage   88.49%   88.50%   +0.01%     
==========================================
  Files         305      306       +1     
  Lines        9621     9643      +22     
==========================================
+ Hits         8514     8535      +21     
- Misses       1107     1108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgsch fgsch marked this pull request as ready for review September 11, 2024 13:45
@fgsch fgsch mentioned this pull request Sep 11, 2024
3 tasks
@TheJulianJES TheJulianJES added new quirk Adds support for a new device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants