Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illuminance formulas to actually reach 0 #3297

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ThinkChaos
Copy link
Contributor

Proposed change

See @javicalle's comment here #1599 (comment)

Additional information

CI failure is unrelated, tests pass if I rebase the branch on 0.0.117.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.18%. Comparing base (915ff9b) to head (0a2d16e).
Report is 20 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/terncy/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3297   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         301      301           
  Lines        9412     9412           
=======================================
  Hits         8300     8300           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant