Announcements #151
Merged
Announcements #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private String message; | ||
| @NotNull | ||
| @Enumerated(EnumType.STRING) | ||
| private boolean scheduled; |
There was a problem hiding this comment.
It's a boolean, so no Enumerated annotation
| private LocalDateTime sentTime = LocalDateTime.now(); | ||
| private boolean automated; | ||
|
|
||
| private transient int seenCount; |
There was a problem hiding this comment.
Localtime will be required I think.
There was a problem hiding this comment.
My comment was about seenCount
| private transient boolean stopEmailPropagation; | ||
| private transient boolean stopFirebasePropagation; | ||
| private transient String icon = "https://zhcet-backend.firebaseapp.com/static/img/icon.png"; | ||
| private transient Function<Announcement, LinkMessage> linkMessageConverter; |
There was a problem hiding this comment.
No transient field needed
|
|
||
| AnnouncementUtils.prepareAnnouncements(model, announcementPage, currentPage); | ||
| List<Announcement> notifications = announcementPage.getContent(); | ||
| model.addAttribute("notifications", notifications); |
| model.addAttribute("minPage", minPage); | ||
| model.addAttribute("maxPage", maxPage); | ||
| model.addAttribute("currentPage", getSafePage(currentPage, totalPages)); | ||
| } |
There was a problem hiding this comment.
We'll reuse notification utils, so no need of recreating this class
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @EqualsAndHashCode(callSuper = false) | ||
| @ToString() |
|
|
||
| public interface AnnouncementRepository extends PagingAndSortingRepository<Announcement, Long> { | ||
| public interface AnnouncementRepository extends JpaRepository<Announcement, Long> { |
|
|
||
| Page<Announcement> findBySenderUserId(String userId, Pageable Page); | ||
| Page<Announcement> findAll(String userId, Pageable pageable); |
There was a problem hiding this comment.
Add a new line above this
|
@prateekj117 Please squash your commits so I can review this easily |
prateekj117
force-pushed
the
announcements
branch
from
5f531da
to
9e763fd
Compare
iamareebjamal
force-pushed
the
announcements
branch
from
92bb43b
to
97ebf3a
Compare
prateekj117
force-pushed
the
announcements
branch
from
25ff874
to
db4df7d
Compare
prateekj117
force-pushed
the
announcements
branch
from
db4df7d
to
3459ac6
Compare
iamareebjamal
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add announcement entity, announcement repository, announcement management service, announcement management controller and announcement utils.
First step for #146