update review

zhangstar333 · Sep 19, 2023 · 7324bef · 7324bef
1 parent b0b4f19
commit 7324bef
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.cpp b/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.cpp
@@ -97,14 +97,8 @@ OperatorPtr DistinctStreamingAggSinkOperatorBuilder::build_operator() {
 
 DistinctStreamingAggSinkLocalState::DistinctStreamingAggSinkLocalState(
         DataSinkOperatorXBase* parent, RuntimeState* state)
-        : AggSinkLocalState<AggDependency, DistinctStreamingAggSinkLocalState>(parent, state) {
-    dummy_mapped_data = std::make_shared<char>('A');
-}
-
-Status DistinctStreamingAggSinkLocalState::init(RuntimeState* state, LocalSinkStateInfo& info) {
-    RETURN_IF_ERROR(Base::init(state, info));
-    return Status::OK();
-}
+        : AggSinkLocalState<AggDependency, DistinctStreamingAggSinkLocalState>(parent, state),
+          dummy_mapped_data(std::make_shared<char>('A')) {}
 
 Status DistinctStreamingAggSinkLocalState::_distinct_pre_agg_with_serialized_key(
         doris::vectorized::Block* in_block, doris::vectorized::Block* out_block) {

diff --git a/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.h b/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.h
@@ -84,7 +84,6 @@ class DistinctStreamingAggSinkLocalState final
     ENABLE_FACTORY_CREATOR(DistinctStreamingAggSinkLocalState);
     DistinctStreamingAggSinkLocalState(DataSinkOperatorXBase* parent, RuntimeState* state);
 
-    Status init(RuntimeState* state, LocalSinkStateInfo& info) override;
     Status close(RuntimeState* state) override;
     Status _distinct_pre_agg_with_serialized_key(vectorized::Block* in_block,
                                                  vectorized::Block* out_block);
@@ -114,4 +113,4 @@ class DistinctStreamingAggSinkOperatorX final
 };
 
 } // namespace pipeline
-} // namespace doris
+} // namespace doris
diff --git a/be/src/pipeline/exec/distinct_streaming_aggregation_source_operator.h b/be/src/pipeline/exec/distinct_streaming_aggregation_source_operator.h
@@ -79,4 +79,4 @@ class DistinctStreamingAggSourceOperatorX final : public AggSourceOperatorX {
 };
 
 } // namespace pipeline
-} // namespace doris
+} // namespace doris