Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
zhangstar333 committed Sep 27, 2023
1 parent 15e4339 commit 2577036
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions be/src/vec/exec/vpartition_sort_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ Status VPartitionSortNode::sink(RuntimeState* state, vectorized::Block* input_bl
_value_places[0]->append_whole_block(input_block, child(0)->row_desc());
} else {
//just simply use partition num to check
//if is TWO_PAHSE_GLOBAL, must be sort all data thought partition num threshold have been exceeded.
if (_topn_phase != TPartTopNPhase::TWO_PAHSE_GLOBAL &&
//if is TWO_PHASE_GLOBAL, must be sort all data thought partition num threshold have been exceeded.
if (_topn_phase != TPartTopNPhase::TWO_PHASE_GLOBAL &&
_num_partition > config::partition_topn_partition_threshold &&
child_input_rows < 10000 * _num_partition) {
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,11 @@ protected void toThrift(TPlanNode msg) {

TPartTopNPhase pTopNPhase;
if (phase == PartitionTopnPhase.ONE_PHASE_GLOBAL_PTOPN) {
pTopNPhase = TPartTopNPhase.ONE_PAHSE_GLOBAL;
pTopNPhase = TPartTopNPhase.ONE_PHASE_GLOBAL;
} else if (phase == PartitionTopnPhase.TWO_PHASE_LOCAL_PTOPN) {
pTopNPhase = TPartTopNPhase.TWO_PAHSE_LOCAL;
pTopNPhase = TPartTopNPhase.TWO_PHASE_LOCAL;
} else if (phase == PartitionTopnPhase.TWO_PHASE_GLOBAL_PTOPN) {
pTopNPhase = TPartTopNPhase.TWO_PAHSE_GLOBAL;
pTopNPhase = TPartTopNPhase.TWO_PHASE_GLOBAL;
} else {
pTopNPhase = TPartTopNPhase.UNKNOWN;
}
Expand Down
6 changes: 3 additions & 3 deletions gensrc/thrift/PlanNodes.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -852,9 +852,9 @@ enum TopNAlgorithm {

enum TPartTopNPhase {
UNKNOWN,
ONE_PAHSE_GLOBAL,
TWO_PAHSE_LOCAL,
TWO_PAHSE_GLOBAL
ONE_PHASE_GLOBAL,
TWO_PHASE_LOCAL,
TWO_PHASE_GLOBAL
}

struct TPartitionSortNode {
Expand Down

0 comments on commit 2577036

Please sign in to comment.