This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
#136 - Disable registration (Christmas bonus specials: β#168 && π #169) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only administrators can register new users with the system. Minimal authorization level needed for accessing registration pages is ROLE_ADMIN.
Considerig that since commit fa31cfe1ee9a only users with at least ROLE_ADMIN authorization level can access the registration page, tests needed to be changed in order to reflect this new state. This will modify the tests for accessing registration page, implementing new steps to handle different users trying to gain access to registration page.
This commit will resolve two problems: 1. Use valid login credential for admin 2. Remove execution order dependency for fos:user tests Because only administrators can have accounts on our application, we can use an admin account to test login and profile page accessibility. Since we've added an admin user to data fixtures, we can now use that data in fos:user tests for login/profile/logout, and remove the ordering dependency between features (up until now we had to run registration scenarios first, and only then could we run login/profile and logout scenarios).
msvrtan
approved these changes
Dec 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent visitors from creating user accounts on website
And provide administrators with ability to create accounts for new administrators
As developers
We need to restrict the access to registration page only to administrators
This PR will allow access to registration page to administrators only, and will add behat scenarios and step implementations for this new rule.
Coincidentally, this also enables closing of #168, because restricting access to registration page caused the removal of tests for registration for new users, but created problems with new registration confirmation (see #169)
Closes #136 and #168