Fix CSV Export/Import on Android #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetavg
force-pushed
the
fix-csv-export-android
branch
from
5939789
to
9b45071
Compare
zetavg
force-pushed
the
fix-csv-export-android
branch
from
9b45071
to
46755be
Compare
|
⚒️ A build has been made for this PR. Check the details below to see how to get it. Details
If you are in the Internal Developer group on TestFlight Nightly, the iOS builds should appear on TestFlight in a few minutes. If you are not in the in the Internal Developer group and want to try the build, please contact a maintainer to get you set up. Tip: Convert this PR to draft to disable these automatic builds. |
|
⚒️ A build has been made for this PR. Check the details below to see how to get it. Details
If you are in the Internal Developer group on TestFlight Nightly, the iOS builds should appear on TestFlight in a few minutes. If you are not in the in the Internal Developer group and want to try the build, please contact a maintainer to get you set up. Tip: Convert this PR to draft to disable these automatic builds. |
zetavg
force-pushed
the
fix-csv-export-android
branch
from
16b0685
to
2fe702c
Compare
|
⚒️ A build has been made for this PR. Check the details below to see how to get it. Details
If you are in the Internal Developer group on TestFlight Nightly, the iOS builds should appear on TestFlight in a few minutes. If you are not in the in the Internal Developer group and want to try the build, please contact a maintainer to get you set up. Tip: Convert this PR to draft to disable these automatic builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file://prefix matters on Android.readRemoteFilefromreact-native-csvis not working on Android. It will always call theerrorcallback with an empty object ({}), and thecompletecallback is never called. To work around this, we useRNFS.readFilefor the file reading, in combination withreadStringfromreact-native-csvto get the work done.