-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update codecov to use Foundry #231
ci: update codecov to use Foundry #231
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -1,5 +1,5 @@ | |||
[profile.default] | |||
src = 'contracts' | |||
src = 'contracts/prototypes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having the following error for coverage without it
node_modules/@uniswap/v2-periphery/contracts/UniswapV2Router02.sol:12:1: Warning: Contract code size exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
contract UniswapV2Router02 is IUniswapV2Router02 {
^ (Relevant source part starts here and spans across multiple lines).
Analysing contracts...
Error:
inline assembly block with no AST attribute
error Command failed with exit code 1.
But I think it makes sense anyway since we only use new contracts for Foundry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i think this should be fine
It doesn't read |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prototypes-contracts-unit-tests-migrate #231 +/- ##
============================================================================
+ Coverage 0 57.44% +57.44%
============================================================================
Files 0 11 +11
Lines 0 235 +235
Branches 0 61 +61
============================================================================
+ Hits 0 135 +135
- Misses 0 100 +100 ☔ View full report in Codecov by Sentry. |
@@ -1,5 +1,5 @@ | |||
[profile.default] | |||
src = 'contracts' | |||
src = 'contracts/prototypes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i think this should be fine
ba11f0f
into
prototypes-contracts-unit-tests-migrate
Update
yarn coverage
to useforge coverage
instead of Hardhat