Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add zeta handling to v2 contracts #214

Merged
merged 101 commits into from
Jul 19, 2024

PR comments

1cc8ad5
Select commit
Loading
Failed to load commit list.
Merged

feat: add zeta handling to v2 contracts #214

PR comments
1cc8ad5
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither succeeded Jul 19, 2024 in 5s

21 new alerts including 2 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 2 medium
  • 5 low

Other Alerts:

  • 14 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 151 in contracts/prototypes/zevm/GatewayZEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Missing inheritance Warning

GatewayZEVM should inherit from IGatewayZEVM

Check notice on line 125 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in GatewayEVMUpgradeTest.depositAndCall(address,bytes):
External calls:
- (deposited,None) = tssAddress.call{value: msg.value}()
Event emitted after the call(s):
- Deposit(msg.sender,receiver,msg.value,address(0),payload)

Check notice on line 138 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in GatewayEVMUpgradeTest.depositAndCall(address,uint256,address,bytes):
External calls:
- IERC20(asset).safeTransferFrom(msg.sender,address(destination),amount)
Event emitted after the call(s):
- Deposit(msg.sender,receiver,amount,asset,payload)

Check notice on line 115 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in GatewayEVMUpgradeTest.deposit(address,uint256,address):
External calls:
- IERC20(asset).safeTransferFrom(msg.sender,address(destination),amount)
Event emitted after the call(s):
- Deposit(msg.sender,receiver,amount,asset,)

Check notice on line 102 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in GatewayEVMUpgradeTest.deposit(address):
External calls:
- (deposited,None) = tssAddress.call{value: msg.value}()
Event emitted after the call(s):
- Deposit(msg.sender,receiver,msg.value,address(0),)

Check warning on line 102 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Boolean equality Warning

GatewayEVMUpgradeTest.deposit(address) compares to a boolean constant:
-deposited == false

Check warning on line 125 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Boolean equality Warning

GatewayEVMUpgradeTest.depositAndCall(address,bytes) compares to a boolean constant:
-deposited == false

Check warning on line 125 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Low-level calls Warning

Low level call in GatewayEVMUpgradeTest.depositAndCall(address,bytes):
- (deposited,None) = tssAddress.call{value: msg.value}()

Check warning on line 102 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Low-level calls Warning

Low level call in GatewayEVMUpgradeTest.deposit(address):
- (deposited,None) = tssAddress.call{value: msg.value}()

Check warning on line 158 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Missing inheritance Warning

GatewayEVMUpgradeTest should inherit from IGatewayEVM

Check warning on line 150 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter GatewayEVMUpgradeTest.setConnector(address)._zetaConnector is not in mixedCase

Check warning on line 149 in contracts/prototypes/evm/GatewayEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter GatewayEVM.setConnector(address)._zetaConnector is not in mixedCase

Check notice on line 27 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Missing zero address validation Low

GatewayEVMUpgradeTest.initialize(address,address)._zetaToken lacks a zero-check on :
- zetaToken = _zetaToken

Check warning on line 59 in contracts/prototypes/zevm/GatewayZEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Low-level calls Warning

Low level call in GatewayZEVM._transferZETA(uint256,address):
- (sent,None) = to.call{value: amount}()

Check warning on line 27 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter GatewayEVMUpgradeTest.initialize(address,address)._zetaToken is not in mixedCase

Check warning on line 37 in contracts/prototypes/evm/GatewayEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter GatewayEVM.initialize(address,address)._tssAddress is not in mixedCase

Check warning on line 37 in contracts/prototypes/evm/GatewayEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter GatewayEVM.initialize(address,address)._zetaToken is not in mixedCase

Check warning on line 27 in contracts/prototypes/evm/GatewayEVMUpgradeTest.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter GatewayEVMUpgradeTest.initialize(address,address)._tssAddress is not in mixedCase

Check warning on line 182 in contracts/prototypes/evm/GatewayEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

GatewayEVM.transferToAssetHandler(address,uint256) ignores return value by IERC20(token).approve(zetaConnector,amount)

Check warning on line 171 in contracts/prototypes/evm/GatewayEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

GatewayEVM.transferFromToAssetHandler(address,address,uint256) ignores return value by IERC20(token).approve(zetaConnector,amount)

Check warning on line 27 in contracts/prototypes/zevm/GatewayZEVM.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter GatewayZEVM.initialize(address)._zetaToken is not in mixedCase