Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify protocol contracts deployment #112

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat: simplify protocol contracts deployment #112

merged 4 commits into from
Jan 23, 2024
+222 −119

Conversation

andresaiello
Copy link
Collaborator

@andresaiello andresaiello commented Dec 22, 2023 •
edited by lumtis
Loading

Summary

  • Add a new script to deploy all the contracts with a single call
  • Keep the option of EXECUTE_PROGRAMMATICALLY to call each script independently

fadeev
fadeev previously approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@socket-security Socket Security
Copy link

socket-security bot commented Jan 18, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +321 159 MB fvictorio

🚮 Removed packages: npm/@nomiclabs/[email protected]

View full report↗︎

lumtis
lumtis approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it has been successfully executed on a network

@andresaiello andresaiello merged commit ab9d643 into main Jan 23, 2024
11 checks passed
@andresaiello andresaiello deleted the andy/pd-5253-simplify-protocol-contracts-deployment branch January 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@fadeev fadeev fadeev left review comments

@CharlieMc0 CharlieMc0 Awaiting requested review from CharlieMc0 CharlieMc0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andresaiello @fadeev @lumtis @brewmaster012