Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added license, fix npm publish #31

Merged
merged 1 commit into from
Sep 23, 2024
Merged

ci: added license, fix npm publish #31

merged 1 commit into from
Sep 23, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Sep 20, 2024

Publishing on npm failed:

https://github.com/zeta-chain/protocol-contracts-solana/actions/runs/10958248436/job/30428068789

I think this is because metaDAOproject/setup-anchor doesn't specify the npm registry when setting up npm:

https://github.com/metaDAOproject/setup-anchor/blob/087a07cc86e8adcca657b9aaf0af9d5d4c504871/action.yml#L22-L24

And GH docs say one should do it:

Please note that you need to set the registry-url to https://registry.npmjs.org/ in setup-node to properly configure your credentials.

Also, added a license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.65%. Comparing base (5ef421e) to head (f12fd3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   11.65%   11.65%           
=======================================
  Files           1        1           
  Lines         163      163           
=======================================
  Hits           19       19           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fadeev
Copy link
Member Author

fadeev commented Sep 20, 2024

@CharlieMc0 please, review.

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fadeev fadeev merged commit 13e04d9 into main Sep 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants