refactor: update swap to use templating #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-janon
reviewed
Jul 25, 2023
omnichain/swap/tasks/interact.ts
Outdated
| const [signer] = await hre.ethers.getSigners(); | ||
| console.log(`🔑 Using account: ${signer.address}\n`); | ||
|
|
||
| const targetZRC20 = getAddress("zrc20" as any, args.destination as any); |
There was a problem hiding this comment.
You're right, we don't need any for zrc20, but we need to cast to any for the network name, because getAddress expects the second argument to be of type ZetaProtocolNetwork and. I think importing types just for arguments is a bit of an overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use templating for the swap tutorial.
Context: zeta-chain/docs#74