Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: increase fee amount to 0.05 gETH to make sure integration tests pass #105

Merged
merged 1 commit into from
Feb 20, 2024
Merged

ci: increase fee amount to 0.05 gETH to make sure integration tests pass #105

merged 1 commit into from
Feb 20, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jan 9, 2024 •
edited
Loading

@fadeev fadeev changed the title increase amount to 0.05 ci: increase fee amount to 0.05 gETH to make sure integration tests pass Jan 10, 2024
@fadeev fadeev marked this pull request as ready for review January 10, 2024 07:02
@fadeev
Copy link
Member Author

fadeev commented Jan 10, 2024

We can of course dynamically get the fee amount, but unless we also make it possible to set the max fee, it could drain the wallet from which these txs are being sent.

@fadeev fadeev merged commit 8c875a3 into main Feb 20, 2024
6 checks passed
@fadeev fadeev deleted the fix-integration-tests branch February 20, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbbeeeee bbbeeeee bbbeeeee approved these changes

@andresaiello andresaiello andresaiello approved these changes

@lucas-janon lucas-janon Awaiting requested review from lucas-janon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fadeev @bbbeeeee @andresaiello