Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading pypirc #421

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix reading pypirc #421

merged 3 commits into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. Fixed reading .pypirc from the home directory.

    @mauritsvanrees
    mauritsvanrees committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c977ffc View commit details
    Browse the repository at this point in the history

  2. First read pypirc, then setup.cfg, then pyproject.toml. 

    Always let the later config file override settings from an earlier config file.
Allow ignoring the two package config files by passing use_package_config=False.  This is only useful in tests, to test some corner cases.

The previous commit, which restored reading a ~/.pypirc, meant that my personal settings, like extra-message, were found, and this broke tests.
It is now shielded again.
I think it now functions like it did previously again.
    @mauritsvanrees
    mauritsvanrees committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8aed13a View commit details
    Browse the repository at this point in the history

  3. Refactor use_package_config=True to omit_package_config_in_test=False. 

    This makes the intention clear.
    @mauritsvanrees
    mauritsvanrees committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    15c0445 View commit details
    Browse the repository at this point in the history