Implemented AsSpan on NetMQFrame #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
reviewed
Jul 23, 2023
src/NetMQ/NetMQFrame.cs
Outdated
| /// <returns>the Buffer as a readonly span</returns> | ||
| public ReadOnlySpan<byte> ToReadOnlySpan() | ||
| { | ||
| return new ReadOnlySpan<byte>(Buffer); |
There was a problem hiding this comment.
This should take the message length into account. The buffer could be longer than the message.
src/NetMQ/NetMQFrame.cs
Outdated
| /// Return an readonly span of bytes that carries the content of this NetMQFrames Buffer. | ||
| /// </summary> | ||
| /// <returns>the Buffer as a readonly span</returns> | ||
| public ReadOnlySpan<byte> ToReadOnlySpan() |
There was a problem hiding this comment.
What do you think about calling this AsSpan, to match similar methods names in the BCL, such as on strings?
|
You are absolutely right, review comments has been fixed. However coverage seems to hanging, and unit test failure seems to be a timing dependent test which fails from time to time. |
dxdjgl
changed the title
|
@drewnoakes would you take another look at the code and let me know if other changes are needed. |
drewnoakes
approved these changes
Aug 7, 2023
|
Thanks Drew for your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.