scripts: west_commands: Remove deprecated west.log #79171
+59
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Documentation
area: Binary Descriptors
area: West
zephyrbot
requested review from
carlescufi,
kartben,
mbolivar-ampere,
nashif,
swinslow and
yonsch
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
west-log
branch
3 times, most recently
from
2cfdd9f
to
f7278f7
Compare
marc-hb
reviewed
Sep 30, 2024
There was a problem hiding this comment.
I see nothing wrong but can you please "divide and conquer" this a bit?
https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#defining-smaller-prs
Maybe split this across 2-4 different PRs? Also better from a Continuous Integration perspective.
The sort of "stacked diffs" git-fu required for such a split should really not be a problem for a west maintainer :-P
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
The global state west.log is deprecated, replace with WestCommand logging. Signed-off-by: Pieter De Gendt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global state
west.logis deprecated, replace withWestCommandlogging.There are still more usages in tree, but those require more effort.