Cavstool debug slot offset by type #79061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
nashif,
softwarecki and
tmleman
lgirdwood
previously approved these changes
Oct 1, 2024
NOTE:There is only one relevant commit in this PR, the last. Please do not waste time in reviewing the earlier commits as they have already been approved here: #78753 |
dcpleung
previously approved these changes
Oct 1, 2024
|
@jsarha setting dnm label as it would seem this PR needs to go after: If that is not the case please remove the label |
Add debug_slot_offset_by_type() for getting debug window slot offset by type identifier. How to find the correct slot and what types there are is documented here: soc/intel/intel_adsp/common/include/adsp_debug_window.h In a normal situation a client program would try to find a specific slot right after DSP boot. Because of that the we can not expect it to be there immediately. Instead we need to try multiple times and give firmware some time to update the debug slot descriptor table. Signed-off-by: Jyri Sarha <[email protected]>
jsarha
force-pushed
the
cavstool_debug_slot_offset_by_type
branch
from
40c3dae
to
204db73
Compare
lgirdwood
approved these changes
Oct 3, 2024
dcpleung
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more commit on top of: #78753
But I made this a separate PR as the review of the PR above is already quite far and I hope to see it merged soon.