samples: drivers: crypto: Align buffers #78692
Open
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-sample-crypto-align-buffers
branch
from
31c5701
to
b4a9c8a
Compare
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-sample-crypto-align-buffers
branch
from
b4a9c8a
to
8f0ff53
Compare
Commit e1e1973 (samples: drivers: crypto: Aligned AES key) introduced the alignment for the key. According to the commit message, the intention was to align the variable at 32 bit boundaries. For this reason, passing 32 to __aligned seems like an error, as its argument is denoted in byte and not bits. Signed-off-by: Reto Schneider <[email protected]>
This change extends what e1e1973 (samples: drivers: crypto: Aligned AES key) has started: For certain architectures (i.e. Si32), the alignment of the used buffers is important as the AES HW engine uses DMA and inherits its restrictions. Signed-off-by: Reto Schneider <[email protected]>
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-sample-crypto-align-buffers
branch
from
8f0ff53
to
1fca4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change completes what e1e1973 (samples: drivers: crypto: Aligned AES key) has started: For certain architectures (i.e. Si32), the alignment of the used buffers is important as the AES HW engine uses DMA and inherits its restrictions.