modules: lz4: add configurability #78652
Conversation
mkaranki
force-pushed
the
lz4-kconfig-to-disable-heap
branch
2 times, most recently
from
53fc264
to
f2f6d42
Compare
|
@mkaranki Thanks for the PR. As with external modules which doesn't have dependencies within zephyr, it needs to moved out. For the same reason we did for FlashDB: #78225 (comment)
Otherwise, am in travel after OSS, will review it during next week and write back. |
Thanks for sharing this info. My vision for lz4 use was to try to use it with Zephyr's fs logging backend so that old log files would get compressed. As there's no general compression API or any kind of "inotify" type of API in Zephyr (yet?), short-cutting here so that fs backend would use lz4, either directly or via a user settable custom callback, to compress the old files. This PR is btw related by accident to #73262. |
Nice idea 👍 |
modules/lz4/CMakeLists.txt
Outdated
| ) | ||
|
|
||
| zephyr_library_compile_definitions_ifdef(CONFIG_LZ4F_HEAPMODE_STACK | ||
| LZ4F_HEAPMODE=0 |
There was a problem hiding this comment.
this is the default. So we can ignore this configuration option all together?
There was a problem hiding this comment.
OK. Configuring same defines that what the defaults are removed for all of these.
They were added there for clarity. This is more minimal now, but it is fuzzier what's the active lz4 config.
| zephyr_library_compile_definitions_ifdef(CONFIG_LZ4HC_HEAPMODE_HEAP | ||
| LZ4HC_HEAPMODE=1 | ||
| ) | ||
| zephyr_library_compile_definitions_ifdef(CONFIG_LZ4HC_HEAPMODE_STACK |
- Add possibility to disable functions that use heap. This is to reduce code size and prevent accidental use of heap. - Add possibility to compile xxhash library, "Extremely Fast Hash algorithm" in. It might be sometimes needed as a standalone, but especially lz4frame requires it. - Add possibility to compile also hc and lz4frame modules. The config options include possibility to configure will heap or stack be used. Defaults are set according to lz4's current defaults. Signed-off-by: Miika Karanki <[email protected]>
mkaranki
force-pushed
the
lz4-kconfig-to-disable-heap
branch
from
f2f6d42
to
0345f00
Compare
Add possibility to disable functions that use heap. This is to reduce code size and prevent accidental use of heap.
Add possibility to compile xxhash library, "Extremely Fast Hash algorithm" in. It might be sometimes needed as a standalone, but especially lz4frame requires it.
Add possibility to compile also hc and lz4frame modules. The config options include possibility to configure will heap or stack be used. Defaults are set according to lz4's current defaults.