kernel: Simplify k_thread_cpu_pin() #78601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npitre
previously approved these changes
Sep 18, 2024
ycsin
reviewed
Sep 18, 2024
kernel/cpu_mask.c
Outdated
| @@ -66,11 +66,7 @@ int k_thread_cpu_mask_disable(k_tid_t thread, int cpu) | |||
|
|
|||
| int k_thread_cpu_pin(k_tid_t thread, int cpu) | |||
| { | |||
| int ret; | |||
| uint32_t mask = BIT(cpu); | |||
There was a problem hiding this comment.
@ycsin - The latest push should fix that CI warning.
Simplifies the k_thread_cpu_pin() implementation to leverage the existing cpu_mask_mod() infrastructure. Signed-off-by: Peter Mitsis <[email protected]>
peter-mitsis
force-pushed
the
pmitsis-cpu-pin
branch
from
ad84d21
to
4fc5785
Compare
cfriedt
approved these changes
Sep 18, 2024
npitre
approved these changes
Sep 19, 2024
ycsin
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the k_thread_cpu_pin() implementation to leverage the existing cpu_mask_mod() infrastructure.