-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: Bluetooth: hci_uart/hci_ipc: CI coverage for nRF53+nRF21 FEM #78587
Merged
nashif
merged 9 commits into
zephyrproject-rtos:main
from
cvinayak:github_hci_ipc_fem_coverage
Sep 26, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
88dec27
soc: nordic: nrf53: Make GPIO pin forwarding selectable
nordicjm 041ee17
samples: Bluetooth: hci_uart/hci_ipc: CI coverage for nRF53+nRF21 FEM
cvinayak 816f1b9
samples: Bluetooth: hci_uart: CI coverage for nRF5340dk cpuapp
cvinayak 6f7b423
samples: Bluetooth: hci_ipc: CI coverage for nRF5340_audio_dk cpunet
cvinayak 8eb986a
samples: Bluetooth: hci_uart: CI coverage for nRF52+nRF21 FEM
cvinayak 11d2dae
samples: Bluetooth: hci_uart: CI coverage for nRF52840
cvinayak 1008e78
samples: Bluetooth: hci_uart: CI coverage for nRF52dk
cvinayak 655a5fb
samples: Bluetooth: hci_uart: CI coverage for nRF52833 DF
cvinayak b61372e
Bluetooth: Controller: Remove unused nRF21 FEM SPI CSN control
cvinayak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
samples/bluetooth/hci_ipc/boards/nrf5340_audio_dk_nrf5340_cpunet_nrf21540_ek.overlay
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/ { | ||
nrf_radio_fem: nrf21540_fem { | ||
compatible = "nordic,nrf21540-fem"; | ||
tx-en-gpios = <&arduino_header 11 GPIO_ACTIVE_HIGH>; /* D5 */ | ||
rx-en-gpios = <&arduino_header 9 GPIO_ACTIVE_HIGH>; /* D3 */ | ||
pdn-gpios = <&arduino_header 15 GPIO_ACTIVE_HIGH>; /* D9 */ | ||
ant-sel-gpios = <&arduino_header 10 GPIO_ACTIVE_HIGH>; /* D4 */ | ||
mode-gpios = <&arduino_header 8 GPIO_ACTIVE_HIGH>; /* D2 */ | ||
supply-voltage-mv = <3000>; | ||
}; | ||
}; | ||
|
||
&radio { | ||
fem = <&nrf_radio_fem>; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
samples/bluetooth/hci_uart/boards/nrf5340_audio_dk_nrf5340_cpuapp_nrf21540_ek.overlay
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* SPDX-License-Identifier: Apache-2.0 */ | ||
|
||
/ { | ||
gpio_fwd: nrf-gpio-forwarder { | ||
compatible = "nordic,nrf-gpio-forwarder"; | ||
status = "okay"; | ||
|
||
nrf21540-gpio-if { | ||
gpios = <&arduino_header 11 0>, /* tx-en-gpios */ | ||
<&arduino_header 9 0>, /* rx-en-gpios */ | ||
<&arduino_header 15 0>, /* pdn-gpios */ | ||
<&arduino_header 10 0>, /* ant-sel-gpios */ | ||
<&arduino_header 8 0>; /* mode-gpios */ | ||
}; | ||
|
||
nrf21540-spi-if { | ||
gpios = <&arduino_header 16 0>, /* cs-gpios */ | ||
<&gpio0 8 0>, /* SPIM_SCK */ | ||
<&gpio0 10 0>, /* SPIM_MISO */ | ||
<&gpio0 9 0>; /* SPIM_MOSI */ | ||
}; | ||
}; | ||
}; | ||
|
||
&uart0 { | ||
compatible = "nordic,nrf-uarte"; | ||
current-speed = <1000000>; | ||
status = "okay"; | ||
hw-flow-control; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole list doesn't make much sense to me. We should allow any platform that has Bluetooth support and an UART. With a list like this, wanting to build/run this with twister on any other platform requires passing an override command line flag (
--force-platform
), which isn't very friendly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have expanded the context up a bit - it's for a test called
sample.bluetooth.hci_uart.nrf5
. So in that limited context theplatform_allow
may indeed be justified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe
integration_platforms
is a subset ofplatform_allow
which ensures these samples are buildable for these boards, and ensured in PR to pass the building.Other boards that support being a Controller only that can be build should be included in the future here.