Add support for imx8mp_evk M7 core for openamp_rsc_table sample #78585
Conversation
This enables openamp_rsc_table sample for imx8mp_evk on M7 core Signed-off-by: Alexandru Lastur <[email protected]>
Currently, Zephyr is always sending back notifications to AP (e.g Linux in our case) on channel 0. But this currently doesn't work if Linux uses other channel id for communication. So, save the channel id used by Linux and use it to send back replies. Signed-off-by: Alexandru Lastur <[email protected]>
zephyrbot
added
area: IPC
|
|
||
| LOG_DBG("%s: msg received", __func__); | ||
| ipm_send(ipm_handle, 0, id, NULL, 0); | ||
| ipm_send(ipm_handle, 0, ipm_ch->channel_id, NULL, 0); |
There was a problem hiding this comment.
copy past from #78228 (comment):
This probably introduces a regression on existing platforms. I can see two assumptions in this patch:
-
The IPM channel ID used for RX and TX is the same. The initial implementation is that
channel id 0 is used for RX and channel id 1 is usedfor Tx. -
You assume that we receive a first message before sending the first one (ipm_ch->channel_id is set in platform_ipm_callback()), which seems like a dangerous assumption to me.
Some simple solutions could be to put the code under platform configuration or, perhaps more generically, to define CONFIG_IPM_RX_CHANNEL_ID and CONFIG_IPM_TX_CHANNEL_ID to configure the channel IDs.
There was a problem hiding this comment.
I think using the CONFIG_ definitions would work for us.
dbaluta
changed the title
Add support for imx8mp_evk M7 core for openamp_rsc_table sample