tests: drivers: build_all: ieee802154: Add native_sim configuration #78518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
force-pushed
the
add_devices_for_build_all_ieee802154
branch
from
c7b81ce
to
fef004e
Compare
The mcr20a driver referencing `MCR20Overwrites.h` which is under `hal/nxp/mcux`. So, put `depends HAS_MCUX` for clarify the dependency. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
add_devices_for_build_all_ieee802154
branch
from
fef004e
to
39b78ea
Compare
soburi
requested review from
rlubos,
tbursztyka,
jukkar and
fgrandel
as code owners
rlubos
reviewed
Sep 17, 2024
| @@ -0,0 +1,80 @@ | |||
| /* | |||
There was a problem hiding this comment.
I'm a bit puzzled here. This seems to be a copy of the overlay file for native_posix platform:
https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/build_all/ieee802154/boards/native_posix.overlay
Why to enforce this overlay for every other platform/configuration?
There was a problem hiding this comment.
I was considering using app.overlay as I do with other build_all-s,
but I submitted the PR incompletely.
I uploaded it with only the necessary fixes.
I'm sorry, but please check again.
The native_sim has already been added to the test cases of `drivers.ieee802154.build.external` is not being appropriately processed because there is no corresponding overlay. Create an overlay as an alias of native_posix.overlay. Also, add the native_sim/native/64 platforms in the same way. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
add_devices_for_build_all_ieee802154
branch
from
39b78ea
to
69c5749
Compare
soburi
changed the title
rlubos
approved these changes
Sep 17, 2024
fgrandel
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native_sim has already been added to the test cases of
drivers.ieee802154.build.externalis not being appropriatelyprocessed because there is no corresponding overlay.
Create an overlay as an alias of native_posix.overlay.
Also, add the native_sim/native/64 platforms in the same way.
The mcr20a driver referencing
MCR20Overwrites.hwhich is underhal/nxp/mcux.So, put
depends HAS_MCUXfor clarify the dependency.