-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the soc from ace30_ptl to ace30 #78474
Change the soc from ace30_ptl to ace30 #78474
Conversation
Hello @gbernatxintel, and thank you very much for your first pull request to the Zephyr project! |
|
||
config SOC | ||
default "ace15_mtpm" if SOC_INTEL_ACE15_MTPM | ||
default "ace20_lnl" if SOC_INTEL_ACE20_LNL | ||
default "ace30_ptl" if SOC_INTEL_ACE30_PTL | ||
default "ace30" if SOC_INTEL_ACE30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should match SOC_*
should be the value of * in the string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion it is ok, if you see other platforms the names are entered without soc_* just simply string. For other manufacturers I randomly checked and also they don't all use soc_* names but just the name of the specific chip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean this should either be default "intel_ace30" if SOC_INTEL_ACE30
or default "ace30" if SOC_ACE30
if not then this will fail at some point in the future when the build system generates these symbols automatically from the soc.yml files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oki, I changed to "ace30" if SOC_ACE30
3674cd4
to
ab4f3ee
Compare
9e3c271
to
28f169d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you separate the whitespace changes into another commit? A simple rename without any changes should show up in git as a simple rename, and makes it easier to review the diff.
28f169d
to
d8ce870
Compare
d8ce870
to
93209ac
Compare
6d73972
to
513b3cf
Compare
In fact, it's hard to carve out a separate commit, because the whole commit is a name change from ace30_ptl to ace30. The general problem was that the soc was misspelled. If there is for example another board based on the same soc then there will be confusion with the definitions. |
When you look at the diff, there are bunch of header files with only whitespace changes and nothing else. There are not |
soc/intel/intel_adsp/ace/Kconfig.soc
Outdated
@@ -32,9 +32,9 @@ config SOC_SERIES | |||
config SOC_TOOLCHAIN_NAME | |||
default "intel_ace15_mtpm" if SOC_INTEL_ACE15_MTPM | |||
default "intel_ace15_mtpm" if SOC_INTEL_ACE20_LNL | |||
default "intel_ace30_ptl" if SOC_INTEL_ACE30_PTL | |||
default "intel_ace30" if SOC_INTEL_ACE30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, keep the toolchain name as intel_ace30_ptl
as it is related to the Zephyr SDK, and the toolchain there is named with _ptl
. Changing this would mean Zephyr SDK can no longer build this platform.
8c93b25
to
fce04e9
Compare
No functional changes were made in this update. Only code formatting issues were corrected. This commit is necessary to preserve Git history continuity for future changes involving the switch from ace30_ptl to ace30. Signed-off-by: Grzegorz Bernat <[email protected]>
Renamed soc from ace30_ptl to ace30. We were previously using the wrong soc name. The correct name is ace30. There is only one ptl platform, but there can be several ace30 platforms. Signed-off-by: Grzegorz Bernat <[email protected]>
fce04e9
to
18fb468
Compare
Hi @gbernatxintel! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
This has broken CI https://github.com/zephyrproject-rtos/zephyr/actions/runs/11009734491/job/30570116372 please submit a fix |
|
Thank you @nordicjm ,I'm checking what's happening in this CI test |
Renamed soc from ace30_ptl to ace30.
We were previously using the wrong soc name.
The correct name is ace30.
There is only one ptl platform, but there can be several ace30 platforms.
Check the commit on the sof project repo:
Change the soc from ace30_ptl to ace30
Dependencies:
thesofproject/sof#9475