Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twister: verify platforms in platform_exclude #78364

Merged
merged 2 commits into from
Sep 16, 2024
Merged

twister: verify platforms in platform_exclude #78364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1abe55
twister: abort on unrecognised platforms
nashif Sep 12, 2024
8dfcaf5
tests: remove misnamed platforms from platform_exclude
nashif Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/pylib/twister/twisterlib/testplan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,8 +767,7 @@ def apply_filters(self, **kwargs):
# If there isn't any overlap between the platform_allow list and the platform_scope
# we set the scope to the platform_allow list
if ts.platform_allow and not platform_filter and not integration and platform_config.get('increased_platform_scope', True):
self.verify_platforms_existence(
ts.platform_allow, f"{ts_name} - platform_allow")
self.verify_platforms_existence(ts.platform_allow, f"{ts_name} - platform_allow")
a = set(platform_scope)
b = set(filter(lambda item: item.name in ts.platform_allow, self.platforms))
c = a.intersection(b)
Expand Down Expand Up @@ -846,6 +845,9 @@ def apply_filters(self, **kwargs):
instance.add_filter("In test case arch exclude", Filters.TESTSUITE)

if ts.platform_exclude and plat.name in ts.platform_exclude:
# works only when we have all platforms parsed, -p limits parsing...
if not platform_filter:
self.verify_platforms_existence(ts.platform_exclude, f"{ts_name} - platform_exclude")
instance.add_filter("In test case platform exclude", Filters.TESTSUITE)

if ts.toolchain_exclude and toolchain in ts.toolchain_exclude:
Expand Down
1 change: 0 additions & 1 deletion tests/kernel/obj_core/obj_core/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ tests:
- qemu_x86
platform_exclude:
- qemu_x86_tiny
- qemu_x86_tiny/ia32/768
1 change: 0 additions & 1 deletion tests/kernel/obj_core/obj_core_stats/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ tests:
- qemu_x86
platform_exclude:
- qemu_x86_tiny
- qemu_x86_tiny/ia32/768
1 change: 0 additions & 1 deletion tests/kernel/obj_core/obj_core_stats_api/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ tests:
- qemu_x86
platform_exclude:
- qemu_x86_tiny
- qemu_x86_tiny/ia32/768
1 change: 0 additions & 1 deletion tests/lib/lockfree/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
tests:
libraries.lockfree:
platform_exclude:
- m5stack_core2 # renode times out
- m2gl025_miv # renode times out
tags:
- lockfree
5 changes: 4 additions & 1 deletion tests/subsys/rtio/rtio_api/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
common:
# renode causes timeouts unfortunately
# xtensa dc233 (with mmu) has a TLB exception for unclear reasons
platform_exclude: m2gl025_miv m5stack_core2 hifive1 qemu_xtensa/dc233c/mmu
platform_exclude:
- m2gl025_miv
- hifive1
- qemu_xtensa/dc233c/mmu
platform_key:
- arch
- simulation
Expand Down
1 change: 0 additions & 1 deletion tests/subsys/zbus/integration/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ tests:
- qemu_cortex_a9
- hifive_unleashed
- fvp_base_revc_2xaemv8a//smp/ns
- fvp_baser_aemv8r_aarch32_smp
tags: zbus
integration_platforms:
- native_sim
Loading