drivers: sdhc: esp32: remove unused code #78311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uLipe
previously approved these changes
Sep 12, 2024
marekmatej
previously approved these changes
Sep 12, 2024
raffarost
previously approved these changes
Sep 12, 2024
sylvioalves
dismissed stale reviews from raffarost, marekmatej, and uLipe
via
9c6c5af
sylvioalves
force-pushed
the
bugfix/code_cleanup_extra
branch
from
ac4550f
to
9c6c5af
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
uLipe
previously approved these changes
Sep 12, 2024
raffarost
previously approved these changes
Sep 12, 2024
wmrsouza
previously approved these changes
Sep 12, 2024
sylvioalves
dismissed stale reviews from kartben, wmrsouza, raffarost, and uLipe
via
b46f24a
sylvioalves
force-pushed
the
bugfix/code_cleanup_extra
branch
from
9c6c5af
to
b46f24a
Compare
|
Sorry folks, needed to add another one. |
raffarost
previously approved these changes
Sep 12, 2024
kartben
previously approved these changes
Sep 12, 2024
wmrsouza
previously approved these changes
Sep 12, 2024
uLipe
previously approved these changes
Sep 13, 2024
marekmatej
previously approved these changes
Sep 13, 2024
Removed unused entry in SDHC driver and initialize variables accordingly. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
dismissed stale reviews from marekmatej, uLipe, wmrsouza, kartben, and raffarost
via
db41166
sylvioalves
force-pushed
the
bugfix/code_cleanup_extra
branch
from
b46f24a
to
db41166
Compare
sylvioalves
requested review from
kartben,
wmrsouza,
raffarost and
marekmatej
|
I had to rebase and update west.yml due to conflict. |
uLipe
approved these changes
Sep 16, 2024
marekmatej
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused entry in SDHC driver and initialize variables accordingly. It updates hal_espressif to also remove one unused definition presented in there which is not caught by CI.