sensor: bme280: opt-in bmp280 support #78213
Open
+77
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the runtime BMP280 support, instead require the support to be specified as a compatible in the devicetree. This assumes that a single board does not have both a BME280 and a BMP280, which is hopefully valid as the BME280 is a strict superset of the BMP280. Signed-off-by: Jordan Yates <[email protected]>
Don't mark the sensor as bad if the very first I2C transaction after boot does not give the value we expect. Retry the ID read up to 5 times before giving up. Signed-off-by: Jordan Yates <[email protected]>
The BME280 driver now requires an additional compatible to signify that the driver is actually being used with a BMP280. Signed-off-by: Jordan Yates <[email protected]>
zephyrbot
added
area: Sensors
zephyrbot
requested review from
avisconti,
dkalowsk,
jeppenodgaard,
kartben,
MaureenHelm,
mmahadevan108,
teburd,
tristan-google,
ubieda and
yperess
|
I don't think the reasoning for the removal of runtime bmp/bme 280 selection is clear enough here. Why do you want to change this? |
The trigger for this was the driver falling over because the first I2C transaction after boot happened to not read the ID correctly. |
teburd
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the runtime BMP280 support, instead require the support to
be specified as a compatible in the devicetree. This assumes that
a single board does not have both a BME280 and a BMP280, which is
hopefully valid as the BME280 is a strict superset of the BMP280.
Support for the BMP280 sampling device ID has been dropped, which is hopefully not controversial given the sensor itself went obsolete in 2018.