Bluetooth: BR: Add listener cb for discovery #78203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Host
area: Bluetooth
area: Samples
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
kartben,
nashif,
sjanc,
Thalley and
theob-pro
lylezhu2012
force-pushed
the
Add_lisenter_cb_for_br_discovery
branch
from
1c69049
to
c95220e
Compare
jhedberg
reviewed
Sep 17, 2024
Comment on lines
43
to
44
| /** private */ | ||
| uint8_t _priv[4]; |
There was a problem hiding this comment.
I was just looking at how this is used, and it seems quite fragile. I'd recommend to clean it up in the same go. These four bytes are cast into the internally defined struct discovery_priv, but there's not even any build assert to ensure that the sizes match up. I'd suggest to just put the private struct in the public header, but cleanly document that it's private data, i.e. something like:
struct bt_br_discovery_result {
struct bt_br_discovery_priv _priv;
...
};
jhedberg
reviewed
Sep 24, 2024
| @@ -38,10 +38,20 @@ extern "C" { | |||
| * @{ | |||
| */ | |||
|
|
|||
| /** @brief BR/EDR discovery private structure */ | |||
There was a problem hiding this comment.
Either drop the doxygen annotation from the comments, or mark this as hidden or private (there's dedicated oxygen syntax for it, IIRC)
| uint8_t pscan_rep_mode; | ||
| /** Resolving remote name*/ | ||
| uint8_t resolving; | ||
| } __packed; |
There was a problem hiding this comment.
I don't think you need the __packed. It's also confusing, since this is normally reserved for protocol structs.
| /** Page scan repetition mode */ | ||
| uint8_t pscan_rep_mode; | ||
| /** Resolving remote name*/ | ||
| uint8_t resolving; |
The results of inquiry and extended inquiry are only reported from application level after the inquiry complete event notified. While the event of inquiry result is notified by controller in real time. It is not a good user experience. Just like scanning of LE, add a listener cb for discovery. When the event of inquiry result, extended inquiry result, or remote name request complete notified, call listener `recv` cb to notify the upper layer. When the event of inquiry complete notified or no pending of remote name request , call listener `timeout` cb to notify the upper layer. Signed-off-by: Lyle Zhu <[email protected]>
Move source code of classic from bluetooth.h to ./classic/classic.h. Signed-off-by: Lyle Zhu <[email protected]>
Remove BR discovery callback from bt_br_discovery_start. All discovery results will be notified through callback registered by bt_br_discovery_cb_register. Signed-off-by: Lyle Zhu <[email protected]>
Due to the update of function bt_br_discovery_start, register discovery callback by calling bt_br_discovery_cb_register. Signed-off-by: Lyle Zhu <[email protected]>
Due to the update of function bt_br_discovery_start, register discovery callback by calling bt_br_discovery_cb_register. Signed-off-by: Lyle Zhu <[email protected]>
Move `struct discovery_priv` to classic.h Rename `struct discovery_priv` to `struct bt_br_discovery_priv`. Modify the structure `struct bt_br_discovery_priv` with `@private`. Change field `_priv` of `struct bt_br_discovery_result` from `uint8_t _priv[4]` to `struct bt_br_discovery_priv _priv`. Signed-off-by: Lyle Zhu <[email protected]>
The `resolving` is used to flag the status that the stack is requesting remote device name. It is better to use the type `bool` instead of the original type `uint8_t`. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
Add_lisenter_cb_for_br_discovery
branch
from
5f51f6d
to
9627db2
Compare
jhedberg
approved these changes
Sep 26, 2024
dleach02
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old PR was closed due to the source branch has been deleted. Create a new PR for the changes.
The results of inquiry and extended inquiry are only reported from application level after the inquiry complete event notified.
While the event of inquiry result is notified by controller in real time.
It is not a good user experience.
Just like scanning of LE, add a listener cb for discovery.
When the event of inquiry result, extended inquiry result, or remote name request complete notified, call listener recv cb to notify the upper layer.
When the event of inquiry complete notified or no pending of remote name request , call listener timeout cb to notify the upper layer.