samples: boards: nrf: nrfx: Fix (D)PPI dependency #78181
Conversation
zephyrbot
requested review from
jaz1-nordic,
kartben,
kl-cruz,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
carlescufi
added
the
Trivial
samples/boards/nrf/nrfx/Kconfig
Outdated
| @@ -2,10 +2,10 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| config NRFX_DPPI | |||
| default $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF_DPPIC)) | |||
| default HAS_HW_NRF_DPPIC | |||
There was a problem hiding this comment.
The actual problem here is that the DT_COMPAT_NORDIC_NRF_DPPIC symbol is not defined yet, since "Kconfig.zephyr" is sourced at the end of this file, and in my opinion this should be corrected by moving the source instruction.
HAS_HW_NRF_DPPIC evaluates to $(dt_compat_enabled,...) so it's not entirely correct here - the thing is that the nrfx_dppi driver is to be enabled when DPPI is available on a given SoC, not only when the corresponding node is enabled in devicetree (it is always enabled now, so currently the effect is the same). It's just a detail, but I think it can be misleading.
There was a problem hiding this comment.
move source Kconfig.zephyr to the top.
Move Kconfig.zephyr above local kconfigs. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
dismissed stale reviews from kartben and carlescufi
via
1b3c01b
nordic-krch
force-pushed
the
fix_sample_nrfx_kconfig
branch
from
b609541
to
1b3c01b
Compare
|
This change was merged as part of #78179. |
Fix dependency which was not correctly working as (D)PPI was enabled by UART and not by this setting. When other modules were not enabling (D)PPI it was not enabled and compilation was failing.