Bluetooth: GMAP: Replace busy bool with atomic #78127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the busy boolean flag with an atomic value. This prevents any race conditions with the GMAP client implementation. Signed-off-by: Emil Gydesen <[email protected]>
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
jhedberg
reviewed
Sep 8, 2024
Comment on lines
-651
to
+658
| if (gmap_cli->busy) { | ||
| if (atomic_test_and_set_bit(gmap_cli->flags, GMAP_CLIENT_FLAG_BUSY)) { |
There was a problem hiding this comment.
Where was gmap_cli->busy getting set to true previously? I can't see you modify that place in this PR. You're adding the analogue to that here (set_bit()), but seems like the original bool was never actually set anywhere?
There was a problem hiding this comment.
Looks like you are correct. It was, incorrectly, never set to true it seems.
Arguably we should add BSIM tests for this behavior as well
jhedberg
approved these changes
Sep 9, 2024
kruithofa
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the busy boolean flag with an atomic value. This prevents any race conditions with the GMAP client implementation.