drivers: i3c: add support for setaasa initialization #78117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XenuIsWatching
force-pushed
the
i3c-setaasa-init
branch
from
71acdd2
to
c6b4bfb
Compare
dcpleung
approved these changes
Sep 6, 2024
Adds a new DTS prop for i3c devices as support for the CCC SETAASA requires prior knowledge of the target if it supports it according to i3c spec v1.1.1 section 5.19.3.23. This will be used as an optimization for bus initialization. Signed-off-by: Ryan McClelland <[email protected]>
XenuIsWatching
force-pushed
the
i3c-setaasa-init
branch
from
c6b4bfb
to
d029656
Compare
gmarull
approved these changes
Sep 9, 2024
Comment on lines
+65
to
+69
| supports-setaasa: | ||
| type: boolean | ||
| description: | | ||
| Indicates if the device supports the CCC SETAASA. If true, it will | ||
| be used as an optimization for bus initialization. |
There was a problem hiding this comment.
nit: if more supports-* are required in the future, a bit field could be more future-proof, but not sure if it can be the case.
There was a problem hiding this comment.
Yeah... it definitely could and that was something was thinking about, but that could come when more "supports" are implemented rather than using an inefficient bool for each of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new DTS prop for i3c devices as support for the CCC SETAASA requires prior knowledge of the target if it supports it according to i3c spec v1.1.1 section 5.19.3.23.
This will be used as an optimization for bus initialization.