net: lwm2m: Bootstrap discovery fixes #78085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second Security object instance for bootstrap case isn't really needed, as the bootstrap server creates own Security object instances anyway. As that object instance had no Short Server ID assigned, it caused failures during bootstrap discovery. Signed-off-by: Robert Lubos <[email protected]>
LwM2M 1.1 specification mentions that the enabler version format was
specified wrongly in LwM2M 1.0 specification, and servers only "may"
accept the old format, which no longer seems to be the case for Leshan.
The URI reference ("</>;") before the enabler version is now mandatory,
if it's missing the bootstrap discovery fails with Leshan. Another
problem are quotes around the enabler version, which seems to be
conditionally accepted only for LwM2M version 1.0. Therefore, keep the
quotes only for that version, to prevent any potential issues with other
servers.
Signed-off-by: Robert Lubos <[email protected]>
kartben
previously approved these changes
Sep 6, 2024
SeppoTakalo
previously approved these changes
Sep 6, 2024
Align bootstrap discovery tests case with the enabler version reporting changes. Signed-off-by: Robert Lubos <[email protected]>
|
Additional commit was needed to align test case with the changes. |
kartben
approved these changes
Sep 6, 2024
jukkar
approved these changes
Sep 6, 2024
SeppoTakalo
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bootstrap discovery response formatting issues, which prevented successful bootstrap with Leshan.
Verified with Leshan, both LwM2M 1.0 and LwM2M 1.1 versions, with and w/o security enabled.
Fixes #77061