tests: drivers: uart_async_api: fix userspace fault #78023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: UART
zephyrbot
requested review from
danieldegrasse,
dbaluta,
dcpleung,
decsny,
manuargue and
MarkWangChinese
EmilioCBen
force-pushed
the
fix/uart_async_api_fault
branch
from
ddb032b
to
547fb59
Compare
decsny
previously requested changes
Sep 5, 2024
There was a problem hiding this comment.
pay attention to what I did in this PR https://github.com/zephyrproject-rtos/zephyr/pull/71900/files
| @@ -0,0 +1,2 @@ | |||
| # Userspace is unable to access the nocache region. | |||
| CONFIG_USERSPACE=n | |||
There was a problem hiding this comment.
can you please explain this change in the commit message, and maybe the 1064 conf/overlay should be a separate commit, is it fixing the same issue? why is it only for rt1064? original issue was reported on rt1010
EmilioCBen
force-pushed
the
fix/uart_async_api_fault
branch
from
547fb59
to
df265b1
Compare
|
Greetings @dcpleung and @andrewboie , I was wondering if you could take a look at this PR? |
|
Which test fails? There is a test |
|
commit message is out of date |
EmilioCBen
force-pushed
the
fix/uart_async_api_fault
branch
from
df265b1
to
e7aeda7
Compare
hakehuang
reviewed
Sep 24, 2024
| @@ -81,9 +81,6 @@ tests: | |||
| harness_config: | |||
| fixture: gpio_loopback | |||
| depends_on: gpio | |||
| platform_allow: | |||
| - nucleo_f746zg | |||
| - nucleo_h723zg | |||
There was a problem hiding this comment.
better not change this but add supported platform instead
There was a problem hiding this comment.
I was trying to see why this was added, what platforms are failing if this is not here? Also I was going to confirm if this part of the yaml file is even working, when I build with these two nucleo platforms, the extra Kconfig did not appear, neither did they appear for any of the rt series which is causing the tests to fail, however if I manually add the extra Kconfigs on the command line, the rt series passes.
@dcpleung @danieldegrasse
What am I missing from the file with this information?
|
Added DNM tag, platforms are not passing right now |
EmilioCBen
force-pushed
the
fix/uart_async_api_fault
branch
2 times, most recently
from
05fb3b6
to
53dbab9
Compare
|
@EmilioCBen , now all board testing PASS with CONFIG_USERSPACE=n for mcux series, but there is a annoying message for this case, for uart driver. why send thie error message this is not related to this fixing PR. maybe we can work this with a new PR. Thanks |
hakehuang
previously approved these changes
Sep 25, 2024
|
Thank you @hakehuang, I can look into this error message! |
decsny
previously approved these changes
Sep 25, 2024
Updated overlay files to test using nocache. and run outside of usersapce mode to avoid inaccessible memory regions when using nocache on RT parts. Also updated testcase file to reflect nocache testing. Signed-off-by: Emilio Benavente <[email protected]>
EmilioCBen
force-pushed
the
fix/uart_async_api_fault
branch
from
53dbab9
to
f240bac
Compare
danieldegrasse
approved these changes
Sep 30, 2024
dcpleung
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71983