Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: net: qemu: minor fixes (socat) #77852

Merged
merged 1 commit into from
Sep 4, 2024
Merged

doc: net: qemu: minor fixes (socat) #77852

merged 1 commit into from
Sep 4, 2024

Conversation

fgrandel
Copy link
Contributor

@fgrandel fgrandel commented Sep 1, 2024 •
edited
Loading

Qemu Networking:

  • The qemu networking docs did not properly document preliminaries.
  • Persistent commands should be started in the background when started in a single terminal.

@fgrandel
doc: net: qemu: minor fixes
f557f9a 
Adds missing preliminaries and recommends to start persistent commands
in the background.

Signed-off-by: Florian Grandel <[email protected]>
@fgrandel fgrandel mentioned this pull request Sep 1, 2024
Merged
@fgrandel fgrandel changed the title doc: net: qemu: minor fixes doc: net: qemu: minor fixes (socat) Sep 1, 2024
jukkar
jukkar reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit about the path

doc/connectivity/networking/qemu_setup.rst Show resolved Hide resolved
doc/connectivity/networking/qemu_setup.rst Show resolved Hide resolved
@fgrandel fgrandel mentioned this pull request Sep 2, 2024
Merged
2 tasks
@fgrandel fgrandel requested a review from jukkar September 2, 2024 12:09
@fgrandel fgrandel assigned rlubos and jukkar and unassigned gmarull and rlubos Sep 4, 2024
@fgrandel
Copy link
Contributor Author

fgrandel commented Sep 4, 2024

Assigned to @jukkar as the net-tools maintainer as these are actually changes referring to net-tools (nothing specifically to do with qemu).

@carlescufi carlescufi merged commit 21481dd into zephyrproject-rtos:main Sep 4, 2024
25 checks passed
@fgrandel fgrandel deleted the fix/doc-qemu-instances branch September 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukkar jukkar jukkar approved these changes

@pdgendt pdgendt pdgendt approved these changes

@rlubos rlubos rlubos approved these changes

@ssharks ssharks Awaiting requested review from ssharks

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@kartben kartben Awaiting requested review from kartben

@gmarull gmarull Awaiting requested review from gmarull

Assignees

@jukkar jukkar

Labels
area: Documentation area: Networking area: QEMU QEMU Emulation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fgrandel @jukkar @pdgendt @rlubos @carlescufi @gmarull @zephyrbot