twister/samples: more filter cleanup for samples and a twister filter improvement #77823
+137
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nashif
commented
Aug 30, 2024
nashif
commented
- twister: add depends_on_one key
- boards: add mmu/mpu as supported feature
- samples: userspace: improve filtering
- samples: mpu: refine filter and documentation
- samples: mpu: rename folder, this is not a test
zephyrbot
added
area: Userspace
zephyrbot
requested review from
abrodkin,
andyross,
ceolin,
dcpleung,
evgeniy-paltsev,
gchwier,
golowanow,
hakehuang,
ithinuel,
KamilxPaszkiet,
kartben,
LukaszMrugala,
PerMac and
ruuddw
dcpleung
previously approved these changes
Aug 30, 2024
nashif
force-pushed
the
topic/sample/filters_1
branch
from
650104d
to
2d01248
Compare
nashif
force-pushed
the
topic/sample/filters_1
branch
2 times, most recently
from
84f7a43
to
71ad3c5
Compare
golowanow
reviewed
Aug 31, 2024
Support dependency on at least one of a list of compatible features, for example: mmu and mpu, one of them will do in a userspace test.. Signed-off-by: Anas Nashif <[email protected]>
Add mpu and mmu as supported features to aid with filtering and coverage in tests and samples. Signed-off-by: Anas Nashif <[email protected]>
Improve filtering and make it more selective to get the optimal coverage. Signed-off-by: Anas Nashif <[email protected]>
refine twister filters and documentation, point to a qemu platform in the samples instead of a hw platform that is not available. Signed-off-by: Anas Nashif <[email protected]>
Rename folder and a few test references in the docs. Signed-off-by: Anas Nashif <[email protected]>
refine smp filters and do not use filter keyword for efficiency. Signed-off-by: Anas Nashif <[email protected]>
Use depends_on and avoid filter in tests where possible. Remove excessive exclusion of platform and instead select platforms to be used for the test. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/sample/filters_1
branch
from
71ad3c5
to
ac87659
Compare
golowanow
reviewed
Sep 4, 2024
overhaul filtering and use platform_key where it makes sense. Some scenarios are limited now with platform_allow to provide enoug coverage for those sample and not consume resource without value in CI. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/sample/filters_1
branch
from
ac87659
to
722df5c
Compare
golowanow
approved these changes
Sep 4, 2024
teburd
approved these changes
Sep 4, 2024
evgeniy-paltsev
requested changes
Sep 6, 2024
| @@ -8,6 +8,8 @@ toolchain: | |||
| - zephyr | |||
| - cross-compile | |||
| - arcmwdt | |||
| supported: | |||
| - mpu | |||
There was a problem hiding this comment.
Hmm, I'm wondering why this the only SNPS platform we add mpu tag to?
There are a lot of snps platforms which have mpu but now they will be filtered out in mpu-related tests.
|
I have the same concern as Evgeniy. I found "mpu" among "supported" on only a single platform in current zephyr. I guess this key was never used before, hence it is not present in board descriptions. Adding dependencies on this keyword can easily pass unnoticed. I can add it to all Nordic boards that have mpu but many others will most likely miss it. |
|
I made an RFC where we can discuss how to speed up CIs without artificially limiting scopes with platform_allow #78403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.