Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: regulator: Add support for AXP2101 PMIC #77804

Closed
wants to merge 0 commits into from

Conversation

ranranff
Copy link

Add initial driver for the AXP2101 PMIC
Support:

  • DCDC1-5
  • LDOA1-A4, LDOB1-B2, LDOC1, LDOD1-D2

Change-Id: I3f93900423ec592a44d7e80a4353672c63cfa3a4

Copy link

Hello @ranranff, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@kartben
Copy link
Collaborator

kartben commented Aug 31, 2024

Thanks much for the PR! I will let others chime in but IMO it would be best to directly introduce this as an MFD device similar to AXP192 since the fuel_gauge side of this PMIC is more than likely something we'll want to support too.

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR has numerous issues, like eg duplicating common DT properties or misusing them like min/max microvolt. Please, check regulators API and contributing guidelines.

@ranranff
Copy link
Author

ranranff commented Sep 6, 2024

this PR has numerous issues, like eg duplicating common DT properties or misusing them like min/max microvolt. Please, check regulators API and contributing guidelines.

Sorry, this has been closed by a mistake. I have create new one #78098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants