-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stm32H5: Add backup sram on additional SOCs #77712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4t0m
force-pushed
the
stm32h5_bkpsram_all
branch
from
August 28, 2024 18:57
ea8bdb1
to
e9dda70
Compare
zephyrbot
requested review from
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
kartben,
marwaiehm-st,
mathieuchopstm and
nashif
August 28, 2024 20:46
str4t0m
force-pushed
the
stm32h5_bkpsram_all
branch
from
August 29, 2024 16:16
e9dda70
to
1c4f962
Compare
str4t0m
force-pushed
the
stm32h5_bkpsram_all
branch
from
August 29, 2024 18:13
1c4f962
to
dac4f9a
Compare
mathieuchopstm
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't think there is a need for anything stronger than the magic value.
erwango
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @str4t0m
This commit moves the backup sram definition to the series base dtsi file, the size is overwritten for socs which have a bigger bkpsram. The backup SRAM is available on all stm32h5 mcus. stm32h503/523/533 have 2k stm32h562/563/573 have 4k Signed-off-by: Thomas Stranger <[email protected]>
Mark backup sram as supported and document it. Signed-off-by: Thomas Stranger <[email protected]>
Stores a magic value togetter with the counter value, and resets the counter in case that magic does not match. A small magic value is not ideal, but should be good enough for the sample and avoids pulling in a additional dependency e.g. on crc. Signed-off-by: Thomas Stranger <[email protected]>
str4t0m
force-pushed
the
stm32h5_bkpsram_all
branch
from
September 1, 2024 17:29
dac4f9a
to
cc7fe18
Compare
FRASTM
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backup SRAM is available on all STM32H5 SOCs, therefore this PR adds the definition for all SOCs.
Additionally:
The magic should be good enough for such a sample and doesn't add any dependencies, but please let me know if you'd prefer to use a crc instead of the magic value.