-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: kernel_service: reorg the commands #77668
shell: kernel_service: reorg the commands #77668
Conversation
3b5cadc
to
6b94ce8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a shell perspective, but perhaps a kernel maintainer might want to comment on it?
Split the `kernel_service.c` into multiple subcommand files, each file would register with the main `kernel` cmd based on the dependencies in Kconfig/CMakeLists.txt. This greatly reduces the number of precompiler directives. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
Parts related to the thread runtime stats are somewhat standalone, refactor it out instead of having two #ifdef and two places. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
6b94ce8
to
56be424
Compare
Rebased to solve merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here because I was summoned, though I'll admit that she'll isn't really my strongest area. This looks like good cleanup though.
Split the
kernel_service.c
into multiple subcommand files, each file would register with the L0kernel
cmd (or L1thread
cmd) based on the dependencies in Kconfig/CMakeLists.txt.This greatly reduces the number of precompiler directives.
ROM target - before
ROM target - this PR
zephyr.bin
size is the same before and after this PR: