[Backport v3.7-branch] Bluetooth: Host: Fix incorrect build assert #77580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make sure `struct closure` fits in the user data, so a user data size of `sizeof(struct closure)` is valid. Signed-off-by: Johan Hedberg <[email protected]> (cherry picked from commit 5736b71)
Very very weird behavior. Deleting the `options & BT_LE_ADV_OPT_USE_NRPA` branch in `id.c:bt_id_set_adv_own_addr` makes the test pass. But add a log in that branch, and you'll see that we never take it in the UT binary.. I don't have time for this, maybe some compiler guru or C language lawyer can look at that decompiled function and figure out the root cause. Someone should also really fix the Bluetooth unit tests and make them run on any Bluetooth related PR. Also nightly. Signed-off-by: Jonathan Rico <[email protected]> (cherry picked from commit 4ab8073)
zephyrbot
added
Backport
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley and
theob-pro
jhedberg
approved these changes
Aug 26, 2024
Thalley
approved these changes
Aug 26, 2024
jori-nordic
approved these changes
Aug 27, 2024
alwa-nordic
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4ab8073~2..4ab8073 from #77543.
Fixes #77594