scripts: twister: Make TwisterStatus autocasting more intuitive #77168
Conversation
LukaszMrugala
added
DNM
zephyrbot
requested review from
gchwier,
golowanow,
hakehuang,
KamilxPaszkiet,
nashif and
PerMac
| @@ -102,8 +102,8 @@ def status(self) -> TwisterStatus: | |||
| def status(self, value : TwisterStatus) -> None: | |||
| # Check for illegal assignments by value | |||
| try: | |||
| key = value.name if isinstance(value, Enum) else value | |||
| self._status = TwisterStatus[key] | |||
| key = value.value if isinstance(value, Enum) else value | |||
There was a problem hiding this comment.
can this common code be just at one place - as a setter of TwisterStatus class - while there is no instance/harness/suite specifics in assignment ?
There was a problem hiding this comment.
Setters are for a property of a class, not the class itself - thus, setters are in classes containing TwisterStatus Enum, not in Enum itself.
You could make a kind-of-a-hack via overloading the _missing_ method of the Enum to do just self._status = TwisterStatus(value) here, where value must not collide with another Enum value and the it will go into _missing_ method in the Enum where we could do casting, checking, etc. It's not very Pythonic, I'd say.
|
This PR's tests should be rerun before merging if #77080 is merged before it. |
LukaszMrugala
force-pushed
the
lmrugalx_status_autocasting_enchancement
branch
from
659ca34
to
763999c
Compare
Rather than writing the Enum key names, like 'FILTER', users probably would be more at-home using the same terms as they can find in their Twister reports, e.g. 'filtered'. Signed-off-by: Lukasz Mrugala <[email protected]>
LukaszMrugala
force-pushed
the
lmrugalx_status_autocasting_enchancement
branch
from
763999c
to
86ebfa7
Compare
Rather than writing the Enum key names, like
'FILTER', users probably would be more at-home using the same terms as they can find in their Twister reports, e.g.'filtered'.Nonewill also be accepted and converted toTwisterStatus.NONE.