bluetooth: honor log panic mode in monitor #76589
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbrauns
force-pushed
the
bt-monitor-panic
branch
from
cb3c9fb
to
175d4a7
Compare
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley and
theob-pro
arbrauns
force-pushed
the
bt-monitor-panic
branch
from
175d4a7
to
2d3581c
Compare
Thalley
previously approved these changes
Aug 2, 2024
jhedberg
previously approved these changes
Aug 2, 2024
arbrauns
force-pushed
the
bt-monitor-panic
branch
from
2d3581c
to
140653a
Compare
Thalley
reviewed
Aug 2, 2024
subsys/bluetooth/host/monitor.c
Outdated
Comment on lines
55
to
57
| #if defined(CONFIG_BT_DEBUG_MONITOR_RTT) || !defined(CONFIG_LOG_MODE_MINIMAL) | ||
| static bool panic_mode; | ||
| #endif |
There was a problem hiding this comment.
Given the use of it is only for CONFIG_BT_DEBUG_MONITOR_RTT then I suggest to move the declaration of the variable to the #if defined(CONFIG_BT_DEBUG_MONITOR_RTT) part on line 100.
arbrauns
force-pushed
the
bt-monitor-panic
branch
from
140653a
to
f9c5031
Compare
Once panic mode is entered, the log write functions are called from an ISR, so must not try to acquire locks. Signed-off-by: Armin Brauns <[email protected]>
arbrauns
force-pushed
the
bt-monitor-panic
branch
from
f9c5031
to
023bfdc
Compare
Thalley
approved these changes
Aug 2, 2024
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
jhedberg
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once panic mode is entered, the log write functions are called from an ISR, so must not try to acquire locks.