use prep_c for xtensa to align with other architectures #75665
Merged
+101
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nashif
commented
Jul 9, 2024
nashif
commented
- xtensa: remove mention of crt0-app.S
- xtensa: introduce prep_c for xtensa
- xtensa: adapt soc code to use prep_c
- xtensa: move arch_kernel_init code into prep_c
nashif
force-pushed
the
topic/arch/xtensa_prep_c
branch
2 times, most recently
from
f5c33a3
to
63cd77b
Compare
zephyrbot
added
platform: Intel ADSP
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
jxstelter,
kv2019i,
lgirdwood,
LucasTambor,
lyakh,
marc-hb,
marcinszkudlinski,
marekmatej,
softwarecki,
sylvioalves,
tmleman and
uLipe
dcpleung
previously approved these changes
Aug 1, 2024
uLipe
previously approved these changes
Aug 1, 2024
andyross
previously approved these changes
Aug 1, 2024
sylvioalves
previously approved these changes
Aug 1, 2024
tmleman
requested changes
Aug 2, 2024
crt0-app.S does not exist, remove it from comments to avoid confusion. Signed-off-by: Anas Nashif <[email protected]>
xtensa is the only architecutre doing thing differently and introduces inconsistency in the init process and dependencies as we attemp to cleanup init levels and remove misused of SYS_INIT. Introduce prep_c for this architecture and align with other architectures. Signed-off-by: Anas Nashif <[email protected]>
Many xtensa target jump from soc code directly into cstart and depend on architecture code being initialized in arch_kernel_init(). Instead of jumping to cstart, jump to newly introduced prep_c similar to all other architectures, where common platfotm initialization will happen. Signed-off-by: Anas Nashif <[email protected]>
arch_kernel_init() was misused for all architecture initialization code that is done in prep_c and prior to cstart on other architectures. arch_kernel_init() is late in the init process and comes after EARLY init level, making xtensa have a very special boot path. Signed-off-by: Anas Nashif <[email protected]>
Restore order of execution. Code that was run in EARLY init level is now too late. Signed-off-by: Anas Nashif <[email protected]>
nashif
dismissed stale reviews from sylvioalves, andyross, uLipe, and dcpleung
via
dbdcb4e
nashif
force-pushed
the
topic/arch/xtensa_prep_c
branch
from
63cd77b
to
dbdcb4e
Compare
should be fixed now. |
|
@tmleman please have another look. |
tmleman
approved these changes
Aug 6, 2024
dcpleung
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.